feat(server): `renderApplication` now accepts a bootstrapping method #49248

alan-agius4 · 2023-02-28T10:46:44Z

The renderApplication now also accepts a bootstrapping function call with return Promise<ApplicationRef>as the first parameter.

Example:

 const bootstrap = () => bootstrapApplication(RootComponent, appConfig);

 const output: string = await renderApplication(bootstrap);

packages/platform-server/src/utils.ts

alan-agius4 · 2023-02-28T10:49:05Z

packages/platform-server/src/utils.ts

@@ -187,20 +212,41 @@ export function renderModule<T>(moduleType: Type<T>, options: {
 * @developerPreview
 */
 export function renderApplication<T>(rootComponent: Type<T>, options: {
+  /** @deprecated use `APP_ID` token to set the application ID. */
  appId: string,
  document?: string|Document,


Since this API is developer preview, can we just remove instead of deprecating?

Correct and also if we are going to keep the current method to pass in a component type deprecate passing in the APP_ID.

I am okay with keeping it for now. Although I did have to add an additional private export to core to check if it's a bootstrap function or a component type.

AndrewKushnir

@alan-agius4 looks great 👍 Just left a couple non-blocking comments.

packages/platform-server/src/utils.ts

@@ -187,20 +212,41 @@ export function renderModule<T>(moduleType: Type<T>, options: {
 * @developerPreview
 */
 export function renderApplication<T>(rootComponent: Type<T>, options: {
+  /** @deprecated use `APP_ID` token to set the application ID. */
  appId: string,
  document?: string|Document,


packages/platform-server/src/utils.ts

alfaproject · 2023-03-01T06:38:31Z

OOC what is this trying to solve? Sorry if it isn't obvious for me

alan-agius4 · 2023-03-01T13:48:07Z

@alfaproject This is needed for a cleaner integration when using SSR and SSG. Where users do not have direct access to renderApplication.

dylhunn

reviewed-for: public-api

AndrewKushnir

Reviewed-for: public-api

AndrewKushnir · 2023-03-01T20:35:58Z

@alan-agius4 it looks like this PR has a merge conflict with the main branch right now (likely due to another PR that removed renderModuleFactory method). Could you please rebase and resolve conflicts when you get a chance? Thank you.

…g method The `renderApplication` now also accepts a bootstrapping function call with return `Promise<ApplicationRef>`as the first parameter. Example: ```ts const bootstrap = () => bootstrapApplication(RootComponent, appConfig); const output: string = await renderApplication(bootstrap); ```

…trapping method

alan-agius4 · 2023-03-01T20:47:48Z

@AndrewKushnir rebased.

Caretaker note: I don’t think this required another presubmit seeing that it’s just a rebase and the changes.

jessicajaniuk · 2023-03-01T22:31:35Z

This PR was merged into the repository by commit b5278cc.

angular-automatic-lock-bot · 2023-04-02T00:09:15Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alan-agius4 added the area: server Issues related to server-side rendering label Feb 28, 2023

ngbot bot added this to the Backlog milestone Feb 28, 2023

angular-robot bot added the detected: feature PR contains a feature commit label Feb 28, 2023

alan-agius4 commented Feb 28, 2023

View reviewed changes

packages/platform-server/src/utils.ts Show resolved Hide resolved

alan-agius4 commented Feb 28, 2023

View reviewed changes

packages/platform-server/src/utils.ts Show resolved Hide resolved

alan-agius4 commented Feb 28, 2023

View reviewed changes

alan-agius4 force-pushed the render-application-bootstrap-fn branch 4 times, most recently from 4784b32 to 420977f Compare February 28, 2023 11:43

alan-agius4 requested a review from AndrewKushnir February 28, 2023 11:46

alan-agius4 marked this pull request as ready for review February 28, 2023 11:58

alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 28, 2023

AndrewKushnir approved these changes Mar 1, 2023

View reviewed changes

pullapprove bot requested review from alxhub, dylhunn and pkozlowski-opensource March 1, 2023 02:07

alan-agius4 force-pushed the render-application-bootstrap-fn branch from 035921b to 04fed46 Compare March 1, 2023 13:46

dylhunn approved these changes Mar 1, 2023

View reviewed changes

pullapprove bot requested a review from jessicajaniuk March 1, 2023 17:06

AndrewKushnir approved these changes Mar 1, 2023

View reviewed changes

alan-agius4 added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 1, 2023

alan-agius4 removed request for pkozlowski-opensource, alxhub and jessicajaniuk March 1, 2023 19:29

AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 1, 2023

alan-agius4 added 2 commits March 1, 2023 20:45

fixup! feat(platform-server): renderApplication now accepts a boots…

be34a3c

…trapping method

alan-agius4 force-pushed the render-application-bootstrap-fn branch from 04fed46 to be34a3c Compare March 1, 2023 20:45

alan-agius4 added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 1, 2023

jessicajaniuk closed this in b5278cc Mar 1, 2023

alan-agius4 deleted the render-application-bootstrap-fn branch March 2, 2023 07:17

angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(server): `renderApplication` now accepts a bootstrapping method #49248

feat(server): `renderApplication` now accepts a bootstrapping method #49248

alan-agius4 commented Feb 28, 2023

alan-agius4 Feb 28, 2023

This comment was marked as duplicate.

alan-agius4 Mar 1, 2023

AndrewKushnir left a comment

This comment was marked as duplicate.

alfaproject commented Mar 1, 2023

alan-agius4 commented Mar 1, 2023

dylhunn left a comment

AndrewKushnir left a comment

AndrewKushnir commented Mar 1, 2023

alan-agius4 commented Mar 1, 2023 •

edited

jessicajaniuk commented Mar 1, 2023

angular-automatic-lock-bot bot commented Apr 2, 2023

feat(server): renderApplication now accepts a bootstrapping method #49248

feat(server): renderApplication now accepts a bootstrapping method #49248

Conversation

alan-agius4 commented Feb 28, 2023

alan-agius4 Feb 28, 2023

Choose a reason for hiding this comment

This comment was marked as duplicate.

alan-agius4 Mar 1, 2023

Choose a reason for hiding this comment

AndrewKushnir left a comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

alfaproject commented Mar 1, 2023

alan-agius4 commented Mar 1, 2023

dylhunn left a comment

Choose a reason for hiding this comment

AndrewKushnir left a comment

Choose a reason for hiding this comment

AndrewKushnir commented Mar 1, 2023

alan-agius4 commented Mar 1, 2023 • edited

jessicajaniuk commented Mar 1, 2023

angular-automatic-lock-bot bot commented Apr 2, 2023

feat(server): `renderApplication` now accepts a bootstrapping method #49248

feat(server): `renderApplication` now accepts a bootstrapping method #49248

alan-agius4 commented Mar 1, 2023 •

edited