Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(common): remove deprecated XhrFactory export from http entrypoint #49251

Closed
wants to merge 1 commit into from
Closed

refactor(common): remove deprecated XhrFactory export from http entrypoint #49251

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

The deprecated XhrFactory export from @angular/common/http has been removed.

BREAKING CHANGE:

Deprecated XhrFactory export from @angular/common/http has been removed. Use XhrFactory from @angular/common instead.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Feb 28, 2023
@pullapprove pullapprove bot requested a review from dylhunn February 28, 2023 11:33
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Feb 28, 2023
@ngbot ngbot bot added this to the Backlog milestone Feb 28, 2023
@JeanMeche
Copy link
Member

nit: You can remove the entries in the depreciation guide

@alan-agius4
refactor(common): remove deprecated XhrFactory export from http e…
0d2108d 
…ntrypoint

The deprecated `XhrFactory` export from `@angular/common/http` has been removed.

BREAKING CHANGE:

Deprecated `XhrFactory` export from `@angular/common/http` has been removed. Use `XhrFactory` from `@angular/common` instead.
@pullapprove pullapprove bot requested a review from alxhub February 28, 2023 11:44
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 28, 2023
AndrewKushnir
AndrewKushnir approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

I didn't find any instances of that symbol (from @angular/common/http) in g3, but would be good to run a TGP just in case.

AndrewKushnir
AndrewKushnir approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@alan-agius4 alan-agius4 added the action: global presubmit The PR is in need of a google3 global presubmit label Feb 28, 2023
dylhunn
dylhunn approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@alan-agius4
Copy link
Contributor Author

Global presubmit: http://test/OCL:512889239:BASE:513154502:1677658513854:fb8c3fba

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: global presubmit The PR is in need of a google3 global presubmit labels Mar 1, 2023
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit c41a216.

@alan-agius4 alan-agius4 deleted the xhr-factory branch March 1, 2023 20:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dylhunn dylhunn dylhunn approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common/http detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alan-agius4 @JeanMeche @AndrewKushnir @dylhunn