feat(core): add mergeApplicationConfig method
#49253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to provide the merge configuration method which will reside in core. DEPRECATED: `ApplicationConfig` has moved, please import `ApplicationConfig` from `@angular/core` instead.
This commits add a utility method to merge multiple `ApplicationConfiguration` into one from left to right. This is useful for server rendering were an application might have several configurations. Usage Example: ```ts const config = mergeApplicationConfig(appConfig, appServerConfig); ```
alan-agius4
added
action: review
angular-robot
bot
added
the
detected: deprecation
alan-agius4
added
the
target: major
alan-agius4
requested review from
AndrewKushnir
and removed request for
pkozlowski-opensource
alan-agius4
changed the title
mergeApplicationConfig method
alan-agius4
force-pushed
the
app-config-merge
branch
from
4f44fbf
to
d157a78
Compare
pullapprove
bot
requested review from
alxhub,
AndrewKushnir and
pkozlowski-opensource
AndrewKushnir
approved these changes
Feb 28, 2023
atscott
approved these changes
Feb 28, 2023
alan-agius4
added
action: merge
alan-agius4
added
merge: caretaker note
|
This PR was merged into the repository by commit 4e9531f. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 1, 2023
This commits add a utility method to merge multiple `ApplicationConfiguration` into one from left to right. This is useful for server rendering were an application might have several configurations. Usage Example: ```ts const config = mergeApplicationConfig(appConfig, appServerConfig); ``` PR Close #49253
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(core): add
mergeApplicationConfigmethodThis commits add a utility method to merge multiple
ApplicationConfigurationinto one from left to right. This is useful for server rendering were an application might have several configurations.Usage Example:
refactor(platform-browser): move
ApplicationConfigto coreThis is needed to provide the merge configuration method which will reside in core.
DEPRECATED:
ApplicationConfighas moved, please importApplicationConfigfrom@angular/coreinstead.