Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport NgOptimizedImage to Angular 14 #49278

Merged
merged 1 commit into from Mar 8, 2023
Merged

Conversation

atcastle
Copy link
Contributor

@atcastle atcastle commented Mar 1, 2023

(New PR created for 14.3.x branch. Old PR: #49230)
This is a PR for the effort by the Chrome Aurora team to backport NgOptimizedImage from Angular 15 to Angular 14. As noted in the updated docs, this is a one-time special project to make these performance enhancements available to more Angular applications, and does not imply a change in Angular release procedure or that any additional features will be backported.

CC: @AndrewKushnir @pkozlowski-opensource @kara

kara
kara previously approved these changes Mar 1, 2023
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aio/content/guide/image-directive.md Show resolved Hide resolved
@atcastle atcastle force-pushed the 14.2.x branch 2 times, most recently from 73b6dd4 to 1479af5 Compare March 2, 2023 02:30
@jessicajaniuk jessicajaniuk added the area: common Issues related to APIs in the @angular/common package label Mar 2, 2023
@ngbot ngbot bot added this to the Backlog milestone Mar 2, 2023
@atcastle atcastle force-pushed the 14.2.x branch 2 times, most recently from 4058e3c to ff84407 Compare March 2, 2023 22:28
@pullapprove pullapprove bot requested a review from mgechev March 2, 2023 22:28
@atcastle atcastle force-pushed the 14.2.x branch 3 times, most recently from 4951cea to b9ff3ab Compare March 7, 2023 19:14
AndrewKushnir
AndrewKushnir previously approved these changes Mar 7, 2023
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great (only 1 tiny comment) 👍

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: lts This PR is targeting a version currently in long-term support labels Mar 7, 2023
@AndrewKushnir AndrewKushnir removed the request for review from atscott March 7, 2023 19:48
Add files and tests from Angular 15 NgOptimizedImage to Angular 14 as a special project by Chrome Aurora
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker state: blocked and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 7, 2023
@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 7, 2023
@AndrewKushnir
Copy link
Contributor

Caretaker note: this PR requires a special handling by the dev-infra team, while it's ready for merge, I'm adding the "blocked" label for now to indicate that.

@devversion
Copy link
Member

devversion commented Mar 8, 2023

FYI: Merging manually via rebase strategy. This PR is only supposed to go into the target branch, so merge tool is not needed

@devversion devversion merged commit 37bbc61 into angular:14.3.x Mar 8, 2023
4 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note state: blocked target: lts This PR is targeting a version currently in long-term support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants