feat(zone.js): jest 29 should ignore uncaught error console log #49325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaLiPassion
added
area: zones
target: minor
JiaLiPassion
force-pushed
the
ignore-error-jest
branch
from
12358cb
to
6cd069a
Compare
Close angular#49110 From jest 29 and jest-preset-angular v13, the module transform logic changed, and now jest-preset-angular use the use the tsconfig target other than the hardcoded one, thymikee/jest-preset-angular#2010 But jest-angular-preset doesn't introduce the @babel/plugin-transform-async-to-generator which is needed by angular since `async/await` still need to be transformed to promise for ES2017+ target. So for now, we disable to output the uncaught error console log for a temp solution, until jest-preset-angular find a proper solution.
JiaLiPassion
force-pushed
the
ignore-error-jest
branch
from
6cd069a
to
5c431da
Compare
AndrewKushnir
approved these changes
Mar 27, 2023
AndrewKushnir
added
the
action: presubmit
AndrewKushnir
added
action: merge
|
This PR was merged into the repository by commit bc412fd. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #49110
In jest 29, should disable uncaught error console.log.