-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform-browser):KeyEventsPlugin should keep the same behavior #49330
Conversation
Close angular#45698 KeyEventsPlugin now has different behavior with EventsPlugin, it will always run inside ngZone with ngZone.runGuarded() no matter the component is initialized inside or outside of NgZone, this PR make sure KeyEventsPlugin bahave the same with other events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR was merged into the repository by commit 2312eb5. |
This has caused a test breakage in Google3. I'll revert this, and we'll have to run a TGP to see if this can land safely. |
…ehavior (angular#49330)" This reverts commit 2312eb5.
Got it, Thank you @jessicajaniuk |
There are definitely some failing tests, but the amount is very small. I'll see if I can address them in the next week so this can land. |
Thank you @jessicajaniuk, if there are anything I can do, please let me know. |
Close #45698
KeyEventsPlugin now has different behavior with EventsPlugin, it will always run inside ngZone with ngZone.runGuarded() no matter the component is initialized inside or outside of NgZone, this PR make sure KeyEventsPlugin bahave the same with other events.