Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): drop support for zone.js versions <=0.12.0 #49331

Closed
wants to merge 1 commit into from
Closed

feat(core): drop support for zone.js versions <=0.12.0 #49331

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

BREAKING CHANGE: zone.js versions 0.11.x and 0.12.x are not longer supported.

@pullapprove pullapprove bot requested a review from AndrewKushnir March 6, 2023 10:55
@alan-agius4 alan-agius4 changed the title feat(core): drop support for zone.js versions <=0.12.0` feat(core): drop support for zone.js versions <=0.12.0` Mar 6, 2023
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit labels Mar 6, 2023
@alan-agius4
feat(core): drop support for zone.js versions <=0.12.0
e778ada 
BREAKING CHANGE: `zone.js` versions `0.11.x` and `0.12.x` are not longer supported.
@alan-agius4 alan-agius4 changed the title feat(core): drop support for zone.js versions <=0.12.0` feat(core): drop support for zone.js versions <=0.12.0 Mar 6, 2023
@alan-agius4 alan-agius4 added area: core Issues related to the framework runtime area: zones labels Mar 6, 2023
@ngbot ngbot bot modified the milestone: Backlog Mar 6, 2023
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Mar 7, 2023 •
edited

@alan-agius4 quick question: should we make sure that we generate the zone.js dependency with correct version (v0.13.0+) in application's package.json? Not sure if it's related, but just wanted to double check.

@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Mar 7, 2023 •
edited

@AndrewKushnir, there is already a PR for that angular/angular-cli#24810

Also, zone.js will be automatically updated to this version when using ng update.

@alan-agius4 alan-agius4 modified the milestones: Backlog, v16-candidates Mar 7, 2023
AndrewKushnir
AndrewKushnir approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

JiaLiPassion
JiaLiPassion approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Mar 7, 2023
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit fdf6197.

@alan-agius4 alan-agius4 deleted the zone-js-update branch March 7, 2023 19:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JiaLiPassion JiaLiPassion JiaLiPassion approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: zones detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v16-candidates
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alan-agius4 @AndrewKushnir @jessicajaniuk @JiaLiPassion