feat(platform-server): add provideServerSupport function to provide server capabilities to an application
#49380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
pullapprove
bot
requested review from
alxhub,
jessicajaniuk and
pkozlowski-opensource
eneajaho
reviewed
Mar 9, 2023
alan-agius4
force-pushed
the
server-support
branch
from
e48d0ae
to
b68d675
Compare
… server capabilities to an application This commit adds the `provideServerSupport()` function that returns the `EnvironmentProviders` needed to setup server rendering without NgModules.
alan-agius4
force-pushed
the
server-support
branch
from
b68d675
to
0cc694e
Compare
jessicajaniuk
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
@alan-agius4 I think it'd be great to avoid the usage of importProvidersFrom and just use the functions that return providers directly.
We could also update the renderApplication providers here to use the new method and replace BrowserModule.withServerTransition with an APP_ID provider. WDYT?
angular/packages/platform-server/src/utils.ts
Lines 242 to 243 in 86fc4d3
…provide server capabilities to an application
AndrewKushnir
approved these changes
Mar 10, 2023
AndrewKushnir
removed
the
action: review
|
This PR was merged into the repository by commit 056d680. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
provideServerSupport()function that returns theEnvironmentProvidersneeded to setup server rendering without NgModules.