refactor(platform-server): remove renderApplication overload that accepts a component
#49463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
angular-robot
bot
added
the
detected: breaking change
alan-agius4
requested review from
jessicajaniuk
and removed request for
pkozlowski-opensource
alan-agius4
force-pushed
the
remove-render-app-overload
branch
from
844fd89
to
04bac13
Compare
jessicajaniuk
approved these changes
Mar 17, 2023
atscott
approved these changes
Mar 17, 2023
alan-agius4
added
action: merge
alan-agius4
requested review from
jessicajaniuk
and removed request for
alxhub,
dylhunn and
jessicajaniuk
|
nit: remove the entry in |
|
@JeanMeche, this API was never deprecated as it was in developer preview. |
AndrewKushnir
approved these changes
Mar 17, 2023
| function isBootstrapFn(value: unknown): value is() => Promise<ApplicationRef> { | ||
| // We can differentiate between a component and a bootstrap function by reading `cmp`: | ||
| return typeof value === 'function' && !getComponentDef(value); | ||
| return _render(platform, bootstrap()); |
There was a problem hiding this comment.
It's amazing how simple the renderApplication function became 🎉
Closed
2 tasks
alan-agius4
force-pushed
the
remove-render-app-overload
branch
2 times, most recently
from
1396d85
to
824e25f
Compare
alan-agius4
force-pushed
the
remove-render-app-overload
branch
from
824e25f
to
b61fc6d
Compare
alan-agius4
added
the
merge: caretaker note
alan-agius4
force-pushed
the
remove-render-app-overload
branch
from
b61fc6d
to
98a14bb
Compare
alan-agius4
added
action: cleanup
…ccepts a component This commit removes the `renderApplication` overload that accepts a root component as the first parameter. BREAKING CHANGE: `renderApplication` method no longer accepts a root component as first argument. Instead, provide a bootstrapping function that returns a `Promise<ApplicationRef>`. Before ```ts const output: string = await renderApplication(RootComponent, options); ``` Now ```ts const bootstrap = () => bootstrapApplication(RootComponent, appConfig); const output: string = await renderApplication(bootstrap, options); ```
… that accepts a component
alan-agius4
force-pushed
the
remove-render-app-overload
branch
from
98a14bb
to
e89fcf6
Compare
alan-agius4
removed
the
action: cleanup
|
This PR was merged into the repository by commit 41f27ad. |
7 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
renderApplicationoverload that accepts a root component as the first parameter.BREAKING CHANGE:
renderApplicationmethod no longer accepts a root component as first argument. Instead, provide a bootstrapping function that returns aPromise<ApplicationRef>.Before
Now