Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): remove entryComponents #49484

Closed
wants to merge 1 commit into from
Closed

feat(core): remove entryComponents #49484

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

entryComponents have been deprecated since version 9, because with Ivy they weren't necessary. These changes remove any remaining references.

BREAKING CHANGE:

  • entryComponents has been deleted from the @NgModule and @Component public APIs. Any usages can be removed since they weren't doing anyting.
  • ANALYZE_FOR_ENTRY_COMPONENTS injection token has been deleted. Any references can be removed.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Mar 20, 2023
@ngbot ngbot bot modified the milestone: Backlog Mar 20, 2023
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit labels Mar 20, 2023
@crisbeto crisbeto modified the milestones: Backlog, v16-candidates Mar 20, 2023
@crisbeto crisbeto marked this pull request as ready for review March 20, 2023 09:11
@pullapprove pullapprove bot requested review from alxhub and mgechev March 20, 2023 09:12
@crisbeto crisbeto added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 20, 2023
@crisbeto
Copy link
Member Author

crisbeto commented Mar 20, 2023 •
edited

Caretaker note: cl/517941577 will have to be patched in together with this change in order to avoid breakages in g3. Copybara will have to be re-run after the change is patched so that the changes are reflected in the CL.

JeanMeche
JeanMeche reviewed Mar 20, 2023
View reviewed changes
aio/content/guide/deprecations.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it conscious choice to have kept the entry and the section about the entryComponents & ANALYZE_FOR_ENTRY_COMPONENTS ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wanted to keep the reference in case folks see an error don't know where it's coming from.

atscott
atscott approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

jessicajaniuk
jessicajaniuk approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@crisbeto
Copy link
Member Author

Passing TGP

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 21, 2023
@crisbeto
feat(core): remove entryComponents
5b1ea03 
`entryComponents` have been deprecated since version 9, because with Ivy they weren't necessary. These changes remove any remaining references.

BREAKING CHANGE:
* `entryComponents` has been deleted from the `@NgModule` and `@Component` public APIs. Any usages can be removed since they weren't doing anyting.
* `ANALYZE_FOR_ENTRY_COMPONENTS` injection token has been deleted. Any references can be removed.
@atscott
Copy link
Contributor

atscott commented Mar 23, 2023

This PR was merged into the repository by commit 585e34b.

@atscott atscott closed this in 585e34b Mar 23, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@mgechev mgechev mgechev approved these changes

@atscott atscott atscott approved these changes

@alxhub alxhub alxhub approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v16-candidates
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@crisbeto @atscott @mgechev @JeanMeche @alxhub @jessicajaniuk