Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler-cli): Add an extended diagnostic for ngSkipHydration #49512

Closed
wants to merge 1 commit into from
Closed

feat(compiler-cli): Add an extended diagnostic for ngSkipHydration #49512

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

This diagnostic ensures that the special attribute ngSkipHydration is not a binding and has no other value than "true" or an empty value.

Fixes #49501

@pullapprove pullapprove bot requested a review from alxhub March 21, 2023 12:24
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 21, 2023
@JeanMeche JeanMeche force-pushed the feature/skip-hydration-extended branch from 978367f to d6897f9 Compare March 21, 2023 12:41
@pkozlowski-opensource pkozlowski-opensource added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 21, 2023
@ngbot ngbot bot added this to the Backlog milestone Mar 21, 2023
@JeanMeche JeanMeche changed the title feat(compiler-cli): Add an extended diagnostic for nSkipHydration feat(compiler-cli): Add an extended diagnostic for ngSkipHydration Mar 21, 2023
AndrewKushnir
AndrewKushnir reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche huge thanks for the help with this change! 👍

The change looks great, I've just left a few minor comments.

aio/content/extended-diagnostics/NG8108.md Outdated Show resolved Hide resolved
aio/content/extended-diagnostics/NG8108.md Outdated Show resolved Hide resolved
aio/content/extended-diagnostics/NG8108.md Outdated Show resolved Hide resolved
aio/content/extended-diagnostics/NG8108.md Outdated Show resolved Hide resolved
goldens/public-api/compiler-cli/extended_template_diagnostic_name.md Outdated Show resolved Hide resolved
packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts Outdated Show resolved Hide resolved
packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts Outdated Show resolved Hide resolved
packages/compiler-cli/src/ngtsc/typecheck/extended/checks/skip_hydration_binding/index.ts Outdated Show resolved Hide resolved
packages/compiler-cli/src/ngtsc/typecheck/extended/checks/skip_hydration_binding/index.ts Outdated Show resolved Hide resolved
@AndrewKushnir AndrewKushnir added core: hydration area: core Issues related to the framework runtime target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 21, 2023
@JeanMeche JeanMeche force-pushed the feature/skip-hydration-extended branch from d6897f9 to 8d10899 Compare March 22, 2023 00:05
@angular-robot angular-robot bot removed the detected: feature PR contains a feature commit label Mar 22, 2023
@JeanMeche JeanMeche force-pushed the feature/skip-hydration-extended branch from 8d10899 to baffe31 Compare March 22, 2023 00:16
AndrewKushnir
AndrewKushnir reviewed Mar 22, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche looks great, just a minor comment related to the error message text.

I also noticed that the commit message refers to the ApplicationRef (likely a commit message that was used in other PR). Could you please update the commit message?

Thank you.

packages/compiler-cli/src/ngtsc/typecheck/extended/checks/skip_hydration_not_static/index.ts Outdated Show resolved Hide resolved
@JeanMeche
feat(compiler-cli): Add an extended diagnostic for nSkipHydration
48272d7 
This diagnostic ensures that the special attribute `ngSkipHydration` is not a binding and has no other value than `"true"` or an empty value.

Fixes angular#49501
@JeanMeche JeanMeche force-pushed the feature/skip-hydration-extended branch from baffe31 to 48272d7 Compare March 22, 2023 08:53
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 22, 2023
AndrewKushnir
AndrewKushnir approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche looks great, thanks for the PR 👍

AndrewKushnir
AndrewKushnir approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 22, 2023
@AndrewKushnir
Copy link
Contributor

Presubmit.

jessicajaniuk
jessicajaniuk approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

reviewed-for: public-api

@AndrewKushnir
Copy link
Contributor

Caretaker note: presubmit is "green".

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Mar 23, 2023
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 23, 2023
@atscott
Copy link
Contributor

atscott commented Mar 23, 2023

This PR was merged into the repository by commit 03d1d00.

@atscott atscott closed this in 03d1d00 Mar 23, 2023
@JeanMeche JeanMeche deleted the feature/skip-hydration-extended branch March 24, 2023 13:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime core: hydration detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Add extended template diagnostic to make sure ngSkipHydration is not a binding
5 participants
@JeanMeche @AndrewKushnir @atscott @jessicajaniuk @pkozlowski-opensource