fix(platform-browser): set nonce attribute in a platform compatible way #49624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: major
crisbeto
approved these changes
Mar 29, 2023
Setting the `nonce` attribute using the property is not supported by Domino. This change update the usage to use `setAttribute` and also add a test to verify that the `nonce` is set when it should.
alan-agius4
force-pushed
the
nonce-fix-server
branch
from
0b171a6
to
74cd7a8
Compare
alan-agius4
requested review from
atscott
and removed request for
jessicajaniuk
AndrewKushnir
approved these changes
Mar 29, 2023
AndrewKushnir
removed
the
action: review
|
This PR was merged into the repository by commit e8e3681. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
nonceattribute using the property is not supported by Domino. This change update the usage to usesetAttributeand also add a test to verify that thenonceis set when it should.//cc @crisbeto