Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove deprecated EventManager method addGlobalEventListener #49645

Closed
wants to merge 1 commit into from
Closed

refactor: remove deprecated EventManager method addGlobalEventListener #49645

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Mar 30, 2023 •
edited

This commit removes the deprecated EventManager method addGlobalEventListener.

BREAKING CHANGE: Deprecated EventManager method addGlobalEventListener has been removed as it is not used by Ivy.

@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Mar 30, 2023
@alan-agius4 alan-agius4 force-pushed the remove-addGlobalEventListener branch from ff2bac7 to c357532 Compare March 30, 2023 10:23
@pkozlowski-opensource
Copy link
Member

Yay! 🎉

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release area: common Issues related to APIs in the @angular/common package labels Mar 30, 2023
@ngbot ngbot bot added this to the Backlog milestone Mar 30, 2023
@alan-agius4 alan-agius4 force-pushed the remove-addGlobalEventListener branch 2 times, most recently from 5e11015 to 8bd31ee Compare March 30, 2023 11:16
@alan-agius4
refactor: remove deprecated EventManager method `addGlobalEventList…
21492fc 
…ener`

This commit removed the deprecated `EventManager` method  `addGlobalEventListener`.

BREAKING CHANGE: Deprecated `EventManager` method `addGlobalEventListener` has been removed as it is not used by Ivy.
@alan-agius4 alan-agius4 force-pushed the remove-addGlobalEventListener branch from 8bd31ee to 21492fc Compare March 30, 2023 11:19
@alan-agius4 alan-agius4 changed the title refactor: remove deprecated EventManager method `addGlobalEventList… refactor: remove deprecated EventManager method addGlobalEventListener Mar 30, 2023
@alan-agius4 alan-agius4 marked this pull request as ready for review March 30, 2023 12:30
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 30, 2023
pkozlowski-opensource
pkozlowski-opensource approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx for the cleanup, I had it on one of my TODO lists, happy to see it removed!

pkozlowski-opensource
pkozlowski-opensource approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core
Reviewed-for: fw-platform-server

@pullapprove pullapprove bot requested a review from dylhunn March 30, 2023 12:35
@alan-agius4
Copy link
Contributor Author

Thnx for the cleanup, I had it on one of my TODO lists, happy to see it removed!

Haha no problem.

@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Mar 30, 2023 •
edited

Blocked on http://cl/520610209

@AndrewKushnir AndrewKushnir modified the milestones: Backlog, v16-candidates Mar 30, 2023
@alan-agius4 alan-agius4 requested review from atscott and removed request for alxhub and jessicajaniuk March 30, 2023 16:44
@pullapprove pullapprove bot requested a review from atscott March 30, 2023 16:47
atscott
atscott approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 30, 2023
@atscott
Copy link
Contributor

atscott commented Mar 30, 2023

This PR was merged into the repository by commit 2703fd6.

@atscott atscott closed this in 2703fd6 Mar 30, 2023
@alan-agius4 alan-agius4 deleted the remove-addGlobalEventListener branch March 30, 2023 16:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@dylhunn dylhunn Awaiting requested review from dylhunn

@jessicajaniuk jessicajaniuk Awaiting requested review from jessicajaniuk

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v16-candidates
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alan-agius4 @pkozlowski-opensource @atscott @AndrewKushnir