Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): expose onDestroy on ApplicationRef #49677

Closed
wants to merge 1 commit into from
Closed

feat(core): expose onDestroy on ApplicationRef #49677

wants to merge 1 commit into from
+1 −2

Conversation

pkozlowski-opensource
Copy link
Member

This change exposes the onDestroy callback on the ApplicationRef as the public API. It is useful for cases where people need to execute cleanup logic on application teardown.

Closes #49087

@pkozlowski-opensource
feat(core): expose onDestroy on ApplicationRef
9a368f3 
This change exposes the onDestroy callback on the ApplicationRef
as the public API. It is useful for cases where people need to
execute cleanup logic on application teardown.

Closes angular#49087
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 3, 2023
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review April 3, 2023 09:06
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Apr 3, 2023
@ngbot ngbot bot modified the milestone: Backlog Apr 3, 2023
jessicajaniuk
jessicajaniuk approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: fw-core, public-api

@pullapprove pullapprove bot requested a review from dylhunn April 3, 2023 14:03
atscott
atscott approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

AndrewKushnir
AndrewKushnir approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 3, 2023
@AndrewKushnir AndrewKushnir removed the request for review from dylhunn April 3, 2023 18:48
@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Apr 3, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Apr 3, 2023

This PR was merged into the repository by commit a5f1737.

@dylhunn dylhunn closed this in a5f1737 Apr 3, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

ApplicationRef's onDestroy method should not be internal
5 participants
@pkozlowski-opensource @dylhunn @atscott @AndrewKushnir @jessicajaniuk