fix(core): make sure that lifecycle hooks are not tracked #49701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
area: core
pkozlowski-opensource
added
the
action: review
alxhub
approved these changes
Apr 4, 2023
Angular lifecycle hooks should never be run as part of the reactive context: we do not expect that signal reads in lifecycle hooks report to any consumers. In the current Angular some of the lifecycle hooks can be flushed early, while executting template update pass. We need to make sure that signal reads in those lifecycle hooks do not register as part of the effect that marks components for check. "
pkozlowski-opensource
force-pushed
the
reactive_ng_on_changes
branch
from
a886575
to
e5a3ba5
Compare
pkozlowski-opensource
added
action: merge
|
caretaker note: I think that G3 failures are unrelated |
|
This PR was merged into the repository by commit df1dfc4. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular lifecycle hooks should never be run as part of the reactive context: we do not expect that signal reads in lifecycle hooks report to any consumers.
In the current Angular some of the lifecycle hooks can be flushed early, while executing template update pass. We need to make sure that signal reads in those lifecycle hooks do not register as part of the effect that marks components for check.