-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): allow async functions in effects #49783
fix(core): allow async functions in effects #49783
Conversation
89adc7c
to
2782f3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: fw-core, public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
This change makes is possible to use async functions (ones returning a promise) as effect run functions. To make it possible, the signature of the effect function changed: effect cleanup function is registered now (using a dedicated callback passed to the effect creation) instead of being returned from the effect function.
2782f3a
to
180615a
Compare
caretaker note: the G3 failures are pre-existing and unrelated |
This PR was merged into the repository by commit ce38be0. |
This change makes is possible to use async functions (ones returning a promise) as effect run functions. To make it possible, the signature of the effect function changed: effect cleanup function is registered now (using a dedicated callback passed to the effect creation) instead of being returned from the effect function. PR Close #49783
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This change makes is possible to use async functions (ones returning a promise) as effect run functions.
To make it possible, the signature of the effect function changed: effect cleanup function is registered now (using a dedicated callback passed to the effect creation) instead of being returned from the effect function.