Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix capitalization of toObservableOptions #49832

Closed
wants to merge 1 commit into from
Closed

fix(core): Fix capitalization of toObservableOptions #49832

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Apr 13, 2023

The capitalization of the interface should be pascal case.

@atscott
fix(core): Fix capitalization of toObservableOptions
85472e3 
The capitalization of the interface should be pascal case.
@atscott atscott added the target: rc This PR is targeted for the next release-candidate label Apr 13, 2023
jessicajaniuk
jessicajaniuk approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from dylhunn April 13, 2023 16:17
@jessicajaniuk jessicajaniuk added area: core Issues related to the framework runtime cross-cutting: signals labels Apr 13, 2023
@ngbot ngbot bot modified the milestone: Backlog Apr 13, 2023
@jessicajaniuk jessicajaniuk added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 13, 2023
AndrewKushnir
AndrewKushnir approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 13, 2023
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 90166be.

jessicajaniuk pushed a commit that referenced this pull request Apr 13, 2023
@atscott @thePunderWoman
fix(core): Fix capitalization of toObservableOptions (#49832)
87549af 
The capitalization of the interface should be pascal case.

PR Close #49832
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cross-cutting: signals target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atscott @jessicajaniuk @AndrewKushnir