-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): include inner ViewContainerRef anchor nodes into ViewRef.rootNodes output #49867
Conversation
…ootNodes output Currently, the `ViewRef.rootNodes` output is missing anchor (comment) nodes for inner `ViewContainerRef`s, when an achor node was created for that instance of a `ViewContainerRef` (which happens in all cases except when an <ng-container> was used as a host for a view container). This issue affects hydration logic, which relies on the number of root nodes within a view to properly determine segments in DOM that belong to a particular view. Resolves angular#49849.
TGP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Caretaker: TGP is green. Safe to merge. |
This PR was merged into the repository by commit d994f85. |
…ootNodes output (#49867) Currently, the `ViewRef.rootNodes` output is missing anchor (comment) nodes for inner `ViewContainerRef`s, when an achor node was created for that instance of a `ViewContainerRef` (which happens in all cases except when an <ng-container> was used as a host for a view container). This issue affects hydration logic, which relies on the number of root nodes within a view to properly determine segments in DOM that belong to a particular view. Resolves #49849. PR Close #49867
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently, the
ViewRef.rootNodes
output is missing anchor (comment) nodes for innerViewContainerRef
s, when an anchor node was created for that instance of aViewContainerRef
(which happens in all cases except when an was used as a host for a view container).This issue affects hydration logic, which relies on the number of root nodes within a view to properly determine segments in DOM that belong to a particular view.
Resolves #49849.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?