Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Ensure effects can be created when Zone is not defined #49890

Closed
wants to merge 1 commit into from
Closed

fix(core): Ensure effects can be created when Zone is not defined #49890

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Apr 17, 2023

Effects should run in the same zone they were created in. However, if ZoneJS is not used at all, effects should just run (without zone). This is similar to what's done in the elements ComponentNgElementStrategy.

fixes #49798

@atscott
fix(core): Ensure effects can be created when Zone is not defined
e551e18 
Effects should run in the same zone they were created in. However, if ZoneJS is not used at all,
effects should just run (without zone). This is similar to what's done
in the elements `ComponentNgElementStrategy`.

fixes angular#49798
@atscott atscott added area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate labels Apr 17, 2023
@atscott atscott requested a review from alxhub April 17, 2023 15:55
@ngbot ngbot bot added this to the Backlog milestone Apr 17, 2023
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Apr 17, 2023
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit a49279d.

jessicajaniuk pushed a commit that referenced this pull request Apr 17, 2023
@atscott @thePunderWoman
fix(core): Ensure effects can be created when Zone is not defined (#4…
fd9dcd3 
…9890)

Effects should run in the same zone they were created in. However, if ZoneJS is not used at all,
effects should just run (without zone). This is similar to what's done
in the elements `ComponentNgElementStrategy`.

fixes #49798

PR Close #49890
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

effect throws error in zoneless mode
3 participants
@atscott @jessicajaniuk @alxhub