Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add newline to hydration mismatch errors #49965

Closed
wants to merge 1 commit into from
Closed

fix(core): add newline to hydration mismatch errors #49965

wants to merge 1 commit into from

Conversation

jessicajaniuk
Copy link
Contributor

This adds a newline after the hydration mismatch errors to provide more separation and readability.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate core: hydration labels Apr 21, 2023
@ngbot ngbot bot added this to the Backlog milestone Apr 21, 2023
@thePunderWoman
fix(core): add newline to hydration mismatch error
7e2775a 
This adds a newline after the hydration mismatch errors to provide more separation and readability.
@jessicajaniuk jessicajaniuk changed the title fix(core): add newline to hydration mismatch error fix(core): add newline to hydration mismatch errors Apr 21, 2023
@jessicajaniuk jessicajaniuk marked this pull request as ready for review April 21, 2023 21:29
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 21, 2023
@jessicajaniuk jessicajaniuk added the action: presubmit The PR is in need of a google3 presubmit label Apr 21, 2023
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Apr 24, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Apr 24, 2023

This PR was merged into the repository by commit be104ec.

@dylhunn dylhunn closed this in be104ec Apr 24, 2023
dylhunn pushed a commit that referenced this pull request Apr 24, 2023
@thePunderWoman @dylhunn
fix(core): add newline to hydration mismatch error (#49965)
6d7be42 
This adds a newline after the hydration mismatch errors to provide more separation and readability.

PR Close #49965
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 25, 2023
@jessicajaniuk jessicajaniuk deleted the error-messages branch November 9, 2023 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: hydration target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jessicajaniuk @dylhunn @AndrewKushnir @thePunderWoman