fix(core): typing of TestBed Common token. #49997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `ComponentFixtureAutoDetect` and `ComponentFixtureNoNgZone` are mistyped. Tokens are only instantiated with booleans.
pkozlowski-opensource
added
area: testing
pkozlowski-opensource
approved these changes
Apr 25, 2023
pullapprove
bot
requested review from
alxhub,
atscott and
pkozlowski-opensource
pkozlowski-opensource
added
target: rc
pkozlowski-opensource
approved these changes
Apr 25, 2023
jessicajaniuk
approved these changes
Apr 25, 2023
jessicajaniuk
added
the
action: global presubmit
|
The TGP is green |
jessicajaniuk
added
action: merge
|
This PR was merged into the repository by commit 5607e0f. |
dylhunn
pushed a commit
that referenced
this pull request
Apr 25, 2023
Both `ComponentFixtureAutoDetect` and `ComponentFixtureNoNgZone` are mistyped. Tokens are only instantiated with booleans. PR Close #49997
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
ComponentFixtureAutoDetectandComponentFixtureNoNgZoneare mistyped. Tokens are only instantiated with booleans.The documentation also only mentions
booleanas value !I mostly see this as a bugfix as the typing is wrong. But is that breaking change acceptable ?
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?