Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform-browser): export deprecated TransferState as type #50015

Closed
wants to merge 1 commit into from
Closed

fix(platform-browser): export deprecated TransferState as type #50015

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

Prior to this commit TransferState re-export could not be used as a type.

Closes #50014

@pullapprove pullapprove bot requested a review from dylhunn April 26, 2023 14:44
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate labels Apr 26, 2023
@ngbot ngbot bot modified the milestone: Backlog Apr 26, 2023
@alan-agius4 alan-agius4 force-pushed the transfer-state-re-export branch 4 times, most recently from 776f592 to 0e91f7b Compare April 26, 2023 14:50
@alan-agius4 alan-agius4 changed the title fix(platform-server): export deprecated TransferState as type fix(platform-browser): export deprecated TransferState as type Apr 26, 2023
@alan-agius4 alan-agius4 force-pushed the transfer-state-re-export branch 2 times, most recently from f8cd76c to 2f74ffb Compare April 26, 2023 14:58
@alan-agius4
fix(platform-browser): export deprecated TransferState as type
fa8aa12 
Prior to this commit `TransferState` re-export could not be used as a type.

Closes angular#50014
@alan-agius4
Copy link
Contributor Author

Caretaker note: G3 failures are existing

Presubmit.

@alan-agius4 alan-agius4 added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 26, 2023
AndrewKushnir
AndrewKushnir approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 26, 2023
jessicajaniuk
jessicajaniuk approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, public-api

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Apr 26, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Apr 26, 2023

This PR was merged into the repository by commit 74194de.

dylhunn pushed a commit that referenced this pull request Apr 26, 2023
@alan-agius4 @dylhunn
fix(platform-browser): export deprecated TransferState as type (#50015
74c925c 
)

Prior to this commit `TransferState` re-export could not be used as a type.

Closes #50014

PR Close #50015
@dylhunn dylhunn closed this in 74194de Apr 26, 2023
@alan-agius4 alan-agius4 deleted the transfer-state-re-export branch April 26, 2023 16:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

'TransferState' refers to a value, but is being used as a type here. Did you mean 'typeof TransferState'?
4 participants
@alan-agius4 @dylhunn @AndrewKushnir @jessicajaniuk