-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform-server): remove dependency on @angular/platform-browser-dynamic
#50064
Conversation
0c84f78
to
95430bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
@alxhub could you please also take a look at the change before the merge?
95430bd
to
0136848
Compare
…-dynamic` Using `@angular/platform-browser-dynamic` is no longer required for JIT scenarios with Ivy. Instead `@angular/compiler` should be imported instead. This change is part of the effort to reduce the server bundles sizes, which is needed to support cloud workers. BREAKING CHANGE: Users that are using SSR with JIT mode will now need to add `import to @angular/compiler` before bootstrapping the application. **NOTE:** this does not effect users using the Angular CLI.
0136848
to
82b51e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
Caretaker note: Presubmit was green prior to the commit message change. |
This PR was merged into the repository by commit 06452af. |
…-dynamic` (#50064) Using `@angular/platform-browser-dynamic` is no longer required for JIT scenarios with Ivy. Instead `@angular/compiler` should be imported instead. This change is part of the effort to reduce the server bundles sizes, which is needed to support cloud workers. BREAKING CHANGE: Users that are using SSR with JIT mode will now need to add `import to @angular/compiler` before bootstrapping the application. **NOTE:** this does not effect users using the Angular CLI. PR Close #50064
…-dynamic` (angular#50064) Using `@angular/platform-browser-dynamic` is no longer required for JIT scenarios with Ivy. Instead `@angular/compiler` should be imported instead. This change is part of the effort to reduce the server bundles sizes, which is needed to support cloud workers. BREAKING CHANGE: Users that are using SSR with JIT mode will now need to add `import to @angular/compiler` before bootstrapping the application. **NOTE:** this does not effect users using the Angular CLI. PR Close angular#50064
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Using
@angular/platform-browser-dynamic
is no longer required for JIT scenarios with Ivy. Instead@angular/compiler
should be imported instead.This change is part of the effort to reduce the server bundles sizes, which is needed to support cloud workers.
BREAKING CHANGE:
Users that are using SSR with JIT mode will now need to add
import to @angular/compiler
before bootstrapping the application.NOTE: this does not effect users using the Angular CLI.