Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zone.js): add __Zone_ignore_on_properties to ZoneGlobalConfigurations #50737

Closed
wants to merge 1 commit into from
Closed

fix(zone.js): add __Zone_ignore_on_properties to ZoneGlobalConfigurations #50737

wants to merge 1 commit into from

Conversation

arturovt
Copy link
Contributor

This commit updates the signature of the ZoneGlobalConfigurations interface and adds missing __Zone_ignore_on_properties property, which may be setup to ignore specific on properties from being patched.

@pullapprove pullapprove bot requested a review from JiaLiPassion June 15, 2023 18:23
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer area: zones labels Jun 16, 2023
@ngbot ngbot bot added this to the Backlog milestone Jun 16, 2023
@arturovt
fix(zone.js): add __Zone_ignore_on_properties to `ZoneGlobalConfigu…
c03b188 
…rations`

This commit updates the signature of the `ZoneGlobalConfigurations` interface and adds
missing `__Zone_ignore_on_properties` property, which may be setup to ignore specific `on`
properties from being patched.
JiaLiPassion
JiaLiPassion approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 31, 2024
jessicajaniuk pushed a commit that referenced this pull request Jan 31, 2024
@arturovt @thePunderWoman
fix(zone.js): add __Zone_ignore_on_properties to `ZoneGlobalConfigu…
05a05b6 
…rations` (#50737)

This commit updates the signature of the `ZoneGlobalConfigurations` interface and adds
missing `__Zone_ignore_on_properties` property, which may be setup to ignore specific `on`
properties from being patched.

PR Close #50737
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit f87f058.

@arturovt arturovt deleted the fix/zone-ignore-properties branch January 31, 2024 15:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JiaLiPassion JiaLiPassion JiaLiPassion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: zones target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arturovt @jessicajaniuk @JiaLiPassion @pkozlowski-opensource @AndrewKushnir