Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: reduce benchmark compare permissions #50909

Merged
merged 1 commit into from Jun 30, 2023
Merged

ci: reduce benchmark compare permissions #50909

merged 1 commit into from Jun 30, 2023

Conversation

devversion
Copy link
Member

Even though the action is already guarded to only run for organization members that manually trigger the action, we can reduce the permissions by using a GitHub token without any permissions to post the result comment.

@devversion
ci: reduce benchmark compare permissions
1ea371d 
Even though the action is already guarded to only run for
organization members that manually trigger the action, we
can reduce the permissions by using a GitHub token without
any permissions to post the result comment.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jun 30, 2023
@ngbot ngbot bot added this to the Backlog milestone Jun 30, 2023
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Jun 30, 2023
josephperrott
josephperrott approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion merged commit 00f0149 into angular:main Jun 30, 2023
15 of 22 checks passed
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 30, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devversion @josephperrott