New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zonejs package exports fixes #51737
Zonejs package exports fixes #51737
Conversation
`typings` is not valid for TypeScript. See: https://www.typescriptlang.org/docs/handbook/esm-node.html for more information.
556eccd
to
6b40d49
Compare
`jest-preset-angular` imports `zone.js` using deep imports. This commit temporary allow this until the correct entry-points are used upstream. See: thymikee/jest-preset-angular#2162
772ead4
to
142f695
Compare
just to be clear, that won't solve the issue of jest-preset-angular on its own since the umd bundle will still be named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR was merged into the repository by commit e86d6db. |
`jest-preset-angular` imports `zone.js` using deep imports. This commit temporary allow this until the correct entry-points are used upstream. See: thymikee/jest-preset-angular#2162 PR Close #51737
@alan-agius4 @JiaLiPassion do we want to cut another Zone.js release to push those changes to NPM? |
Yes @AndrewKushnir |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…#51737) `typings` is not valid for TypeScript. See: https://www.typescriptlang.org/docs/handbook/esm-node.html for more information. PR Close angular#51737
`jest-preset-angular` imports `zone.js` using deep imports. This commit temporary allow this until the correct entry-points are used upstream. See: thymikee/jest-preset-angular#2162 PR Close angular#51737
fix(zone.js): temporary allow deep imports
jest-preset-angular
importszone.js
using deep imports. This commit temporary allow this until the correct entry-points are used upstream. See: thymikee/jest-preset-angular#2162fix(zone.js): rename
typings
conditional export totypes
typings
is not valid for TypeScript. See: https://www.typescriptlang.org/docs/handbook/esm-node.html for more information.