We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler
Yes
Below is the css and unit test i wrote to confirm it's generated incorrectly.
original css
:host[size=full]>espresso-modal-container>espresso-modal-content-container { min-width: 100vw; max-width: 100vw; width: 100vw; min-height: 100%; max-height: 100%; height: 100% }
expected css
[size=full][HOSTA]>espresso-modal-container[CONTENTA]>espresso-modal-content-container[CONTENTA] { min-width: 100vw; max-width: 100vw; width: 100vw; min-height: 100%; max-height: 100%; height: 100% }
actual css
[size=full]>espresso-modal-container>espresso-modal-content-container[HOSTA] { min-width: 100vw; max-width: 100vw; width: 100vw; min-height: 100%; max-height: 100%; height: 100% }
angular unit test i added to shadow_css_spec.ts
describe('ShadowCss', () => { it('should handle attribute before host', () => { const css = ':host[size=full]>espresso-modal-container>espresso-modal-content-container{min-width:100vw;max-width:100vw;width:100vw;min-height:100%;max-height:100%;height:100%}'; const expected = '[size=full][HOSTA]>espresso-modal-container[CONTENTA]>espresso-modal-content-container[CONTENTA]{min-width:100vw;max-width:100vw;width:100vw;min-height:100%;max-height:100%;height:100%}'; expect(shim(css, 'CONTENTA', 'HOSTA')).toEqualCss(expected); });
all is in above details
incorrect css generated as shown and reproduced via the unit test above
ng version
Angular CLI: 16.1.15 Node: 18.13.0 Package Manager: yarn 1.22.19 OS: darwin x64
confirmed this works as expected in 14, not sure about 15
The text was updated successfully, but these errors were encountered:
Hi, there is a pending PR to fix this regression : #49118
Dupe of #49100
Sorry, something went wrong.
This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
No branches or pull requests
Which @angular/* package(s) are the source of the bug?
compiler
Is this a regression?
Yes
Description
Below is the css and unit test i wrote to confirm it's generated incorrectly.
original css
:host[size=full]>espresso-modal-container>espresso-modal-content-container {
min-width: 100vw;
max-width: 100vw;
width: 100vw;
min-height: 100%;
max-height: 100%;
height: 100%
}
expected css
[size=full][HOSTA]>espresso-modal-container[CONTENTA]>espresso-modal-content-container[CONTENTA] {
min-width: 100vw;
max-width: 100vw;
width: 100vw;
min-height: 100%;
max-height: 100%;
height: 100%
}
actual css
[size=full]>espresso-modal-container>espresso-modal-content-container[HOSTA] {
min-width: 100vw;
max-width: 100vw;
width: 100vw;
min-height: 100%;
max-height: 100%;
height: 100%
}
angular unit test i added to shadow_css_spec.ts
describe('ShadowCss', () => {
it('should handle attribute before host', () => {
const css = ':host[size=full]>espresso-modal-container>espresso-modal-content-container{min-width:100vw;max-width:100vw;width:100vw;min-height:100%;max-height:100%;height:100%}';
const expected = '[size=full][HOSTA]>espresso-modal-container[CONTENTA]>espresso-modal-content-container[CONTENTA]{min-width:100vw;max-width:100vw;width:100vw;min-height:100%;max-height:100%;height:100%}';
expect(shim(css, 'CONTENTA', 'HOSTA')).toEqualCss(expected);
});
Please provide a link to a minimal reproduction of the bug
all is in above details
Please provide the exception or error you saw
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
confirmed this works as expected in 14, not sure about 15
The text was updated successfully, but these errors were encountered: