feat(zone.js): remove legacy files and access to deep imports #51752
+284
−381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes access to deep imports and `zone-testing-bundle` and `zone-testing-node-bundle` This commit removed access to deep and legacy `dist` imports. `zone-testing-bundle` and `zone-testing-node-bundle` are also no longer generated. BREAKING CHANGE: Deep and legacy `dist/` imports like `zone.js/bundles/zone-testing.js` and `zone.js/dist/zone` are no longer allowed. `zone-testing-bundle` and `zone-testing-node-bundle` are also no longer part of the package. The proper way to import `zone.js` and `zone.js/testing` is: ```js import 'zone.js'; import 'zone.js/testing'; ```
alan-agius4
added
the
target: major
angular-robot
bot
added
detected: breaking change
…839c18c7f6db81` This is needed to consume a zone.js related import fix. angular/dev-infra#1383
angular-robot
bot
added
the
area: build & ci
This commits add missing `override` modifier to `HostBindingCompilationJob` class members.
alan-agius4
added
the
action: review
pullapprove
bot
requested review from
AndrewKushnir,
JiaLiPassion and
josephperrott
AndrewKushnir
approved these changes
Sep 13, 2023
alan-agius4
added
action: merge
|
This PR was merged into the repository by commit 70e88f8. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 14, 2023
…839c18c7f6db81` (#51752) This is needed to consume a zone.js related import fix. angular/dev-infra#1383 PR Close #51752
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…r#51752) This commit removes access to deep imports and `zone-testing-bundle` and `zone-testing-node-bundle` This commit removed access to deep and legacy `dist` imports. `zone-testing-bundle` and `zone-testing-node-bundle` are also no longer generated. BREAKING CHANGE: Deep and legacy `dist/` imports like `zone.js/bundles/zone-testing.js` and `zone.js/dist/zone` are no longer allowed. `zone-testing-bundle` and `zone-testing-node-bundle` are also no longer part of the package. The proper way to import `zone.js` and `zone.js/testing` is: ```js import 'zone.js'; import 'zone.js/testing'; ``` PR Close angular#51752
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…839c18c7f6db81` (angular#51752) This is needed to consume a zone.js related import fix. angular/dev-infra#1383 PR Close angular#51752
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ngular#51752) This commits add missing `override` modifier to `HostBindingCompilationJob` class members. PR Close angular#51752
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes access to deep imports and
zone-testing-bundleandzone-testing-node-bundleThis commit removed access to deep and legacy
distimports.zone-testing-bundleandzone-testing-node-bundleare also no longer generated.BREAKING CHANGE:
Deep and legacy
dist/imports likezone.js/bundles/zone-testing.jsandzone.js/dist/zoneare no longer allowed.zone-testing-bundleandzone-testing-node-bundleare also no longer part of the package.The proper way to import
zone.jsandzone.js/testingis: