Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Image assets do not load in preview on docs-code #52666

Closed
twerske opened this issue Sep 1, 2023 · 4 comments
Closed

docs: Image assets do not load in preview on docs-code #52666

twerske opened this issue Sep 1, 2023 · 4 comments
Assignees
@9kubczas4
Labels
area: adev Angular.dev documentation area: docs-infra Angular.dev application and infrastructure good first issue An issue that is suitable for first-time contributors; often a documentation issue. help wanted An issue that is suitable for a community contributor (based on its complexity/scope). P2 The issue is important to a large percentage of users, with a workaround
Projects
adev
Milestone
Backlog

Comments

@twerske
Copy link
Contributor

twerske commented Sep 1, 2023 •
edited

Code examples with the preview should be able to load relevant images in their src
@twerske twerske added P0 Issue that causes an outage, breakage, or major function to be unusable, with no known workarounds P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed P0 Issue that causes an outage, breakage, or major function to be unusable, with no known workarounds labels Sep 6, 2023
@twerske twerske added the bug label Sep 15, 2023
@twerske twerske assigned 9kubczas4 and unassigned 9kubczas4 Sep 18, 2023
@twerske twerske changed the title bug: Assets don’t load in preview docs: Image assets do not load in preview on docs-code Oct 28, 2023
@josephperrott josephperrott added area: adev Angular.dev documentation and removed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful bug labels Nov 8, 2023
@ngbot ngbot bot added this to the needsTriage milestone Nov 8, 2023
@josephperrott josephperrott transferred this issue from another repository Nov 8, 2023
@twerske twerske added area: docs-infra Angular.dev application and infrastructure good first issue An issue that is suitable for first-time contributors; often a documentation issue. area: adev Angular.dev documentation help wanted An issue that is suitable for a community contributor (based on its complexity/scope). and removed area: adev Angular.dev documentation labels Nov 8, 2023
@twerske twerske added the P2 The issue is important to a large percentage of users, with a workaround label Nov 29, 2023
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 29, 2023
@mgechev mgechev added this to To do in adev Feb 1, 2024
@hansireit
Copy link
Contributor

I will take a look at this.

Is it a known issue that the all tutorials except the intro fail in the latest angular/main with:
image

This is because source code is fetched with learn-angular/components-in-angular but it should include the step-index like learn-angular/1-components-in-angular.

@bencodezen bencodezen moved this from To Do to In Progress in adev Mar 14, 2024
This was referenced Mar 20, 2024
Closed
Closed
Closed
Closed
Closed
@bencodezen bencodezen moved this from In Progress to Done in adev Mar 25, 2024
@bencodezen bencodezen reopened this Apr 2, 2024
@bencodezen
Copy link
Contributor

This still an issue as referenced in #55163 (comment)

@JeanMeche
Copy link
Member

My Bad, this particular issue is resolved, It was about this images in the markdown files.
But we still have an issue with the images in the webcontainers app.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@9kubczas4 9kubczas4

Labels
area: adev Angular.dev documentation area: docs-infra Angular.dev application and infrastructure good first issue An issue that is suitable for first-time contributors; often a documentation issue. help wanted An issue that is suitable for a community contributor (based on its complexity/scope). P2 The issue is important to a large percentage of users, with a workaround
Projects
adev
Done
Milestone
Backlog
Development

No branches or pull requests
6 participants
@JeanMeche @bencodezen @josephperrott @twerske @hansireit @9kubczas4