-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip to Main Content Does not work creating severe accessibility issues #53015
Comments
Thanks for the report! Once the app is buildable I'd love to review a PR for contributors interested here! |
Hey @twerske, |
The team still need to integrate the adev site into the build process ! The app isn't runnable locally until this has been done. |
I did take a look at it, the button works fine but has no purpose on the home page. There is no content to focus on. Or maybe we should focus on the editor ? |
@JeanMeche Agreed on your findings. Instead of the editor, what do you think of having it focus on the "Learn Angular" button which is where we primarily want people to go? |
It needs to say skip to main content.Sent from my iPhoneOn Mar 25, 2024, at 12:32 PM, Ben Hong ***@***.***> wrote:
@JeanMeche Agreed on your findings. Instead of the editor, what do you think of having it focus on the "Learn Angular" button which is where we primarily want people to go?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sorry, I read that wrong. It just needs to go to the first non-repetitive element.Sent from my iPhoneOn Mar 25, 2024, at 12:32 PM, Ben Hong ***@***.***> wrote:
@JeanMeche Agreed on your findings. Instead of the editor, what do you think of having it focus on the "Learn Angular" button which is where we primarily want people to go?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@stot3 I took a look at the code and it seems like the issue is that the button looks for an H1 and there doesn't seem to be on the home page. I'll try and dive deeper to see what we can do to allow users to go to content. |
Closed via #55052 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Describe the problem that you experienced
Clicking the Skip to Main Content Button does not skip to main content.
Enter the URL of the topic with the problem
http://angular.dev
Describe what you were looking for in the documentation
The skip to main content button should skip to the first non-repeated element.
Describe the actions that led you to experience the problem
Clicking the skip to content button.
Describe what you want to experience that would fix the problem
The skip to main content button should skip to the first non-repeated element.
Add a screenshot if that helps illustrate the problem
No response
If this problem caused an exception or error, please paste it here
No response
If the problem is browser-specific, please specify the device, OS, browser, and version
No response
Provide any additional information here in as much as detail as you can
No response
The text was updated successfully, but these errors were encountered: