Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zone.js eradicates Promise.withResolvers #53507

Closed
dancrumb opened this issue Dec 11, 2023 · 3 comments
Closed

zone.js eradicates Promise.withResolvers #53507

dancrumb opened this issue Dec 11, 2023 · 3 comments

Comments

@dancrumb
Copy link

Which @angular/* package(s) are the source of the bug?

zone.js

Is this a regression?

No

Description

This library replaces window.Promise with window.ZoneAwarePromise.

In doing so, it eradicates the withResolvers static method

Please provide a link to a minimal reproduction of the bug

n/a

Please provide the exception or error you saw

This is quite a simple case of replacing a native Class with your own and not propagating method calls properly.

Go to any page that doesn't use `zone.js` and running `Promise.withResolvers()` returns a value.

Go to any page that _does_ use `zone.js` and running `Promise.withResolvers()` returns an error.

Please provide the environment you discovered this bug in (run ng version)

No response

Anything else?

See open-telemetry/opentelemetry-js#4354

@ngbot ngbot bot added this to the needsTriage milestone Dec 11, 2023
@JeanMeche
Copy link
Member

One additional precision, Promise.withResolvers reached stage 4 recently, so support is expected !

@alan-agius4
Copy link
Contributor

Closed via #53514

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants