Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update input/output guide links #54135

Closed
wants to merge 1 commit into from
Closed

docs: update input/output guide links #54135

wants to merge 1 commit into from

Conversation

swami-sanapathi
Copy link
Contributor

Closes: #54134

@angular-robot angular-robot bot added the area: docs Related to the documentation label Jan 28, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 28, 2024
@angular-robot angular-robot bot removed the area: docs Related to the documentation label Jan 28, 2024
@ngbot ngbot bot removed this from the Backlog milestone Jan 28, 2024
@swami-sanapathi swami-sanapathi changed the title docs(fix): correct outputs guide in tutorials fix(docs): correct outputs guide in tutorials Jan 28, 2024
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jan 28, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 28, 2024
@JeanMeche
Copy link
Member

Hi, thanks for helping us improve the docs, what do you think of having 2 links here for input and outputs ?

@swami-sanapathi
Copy link
Contributor Author

Sure, can we set the title of the docs-pill-row as 'Sharing data between parent and child directives and components'?

@JeanMeche
Copy link
Member

What about using the title of the dedicates pages :

@swami-sanapathi swami-sanapathi changed the title fix(docs): correct outputs guide in tutorials docs: update input/output guide links Jan 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

Deployed adev-preview for 0dd9a39 to: https://ng-dev-previews-fw--pr-angular-angular-54135-adev-prev-8setnehg.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@swami-sanapathi
Copy link
Contributor Author

That's great, I've updated with changes.

jessicajaniuk
jessicajaniuk approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 29, 2024
jessicajaniuk pushed a commit that referenced this pull request Jan 29, 2024
@swami-sanapathi @thePunderWoman
docs: update input/output guide links (#54135)
96ca49d 
PR Close #54135
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 45288f7.

nikvarma pushed a commit to nikvarma/angular that referenced this pull request Jan 31, 2024
@swami-sanapathi @nikvarma
docs: update input/output guide links (angular#54135)
19d9244 
PR Close angular#54135
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2024
@swami-sanapathi swami-sanapathi deleted the fix/docs-guide-output branch March 17, 2024 05:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

https://angular.dev/tutorials/first-app/inputs BAD LINK
3 participants
@swami-sanapathi @JeanMeche @jessicajaniuk