AbortController error with walletconnect lib after zone.js 0.14.3 update

[imaksp]

Which @angular/* package(s) are the source of the bug?

zone.js

Is this a regression?

Yes

Description

After zone.js update to 0.14.3, walletconnect integration is breaking in our app. earlier it was opening QR code modal without any error.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

core.mjs:11806 ERROR TypeError: Cannot set property signal of [object AbortController] which has only a getter
    at zone.js:1957:38
    at ae.addKeyboardEvents (index.js:1:67056)
    at ae.onOpenModalEvent (index.js:1:66362)
    at index.js:1:65722
    at index.js:1:7509
    at vanilla.mjs:242:11
    at _ZoneDelegate.invoke (zone.js:368:26)
    at Object.onInvoke (core.mjs:14778:33)
    at _ZoneDelegate.invoke (zone.js:367:52)
    at _Zone.run (zone.js:129:43)

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 17.1.1
Node: 18.18.2
Package Manager: yarn 1.22.19
OS: darwin arm64

Angular: 17.1.1
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1701.1
@angular-devkit/build-angular   17.1.1
@angular-devkit/core            17.1.1
@angular-devkit/schematics      17.1.1
@schematics/angular             17.1.1
rxjs                            7.8.1
typescript                      5.3.3
zone.js                         0.14.3

Anything else?

For now solved by downgrading zone.js to 0.14.2.
This line from latest zone.js is throwing error:

angular/packages/zone.js/lib/common/events.ts

Line 480 in c213a4e

taskData.options.signal = undefined;

[JiaLiPassion]

@imaksp , could you provide a reproduce repo? thanks.

[JoostK]

This will happen when passing an AbortController as options for addEventListener. That's a bit odd but should work, considering that it does have the signal field (but it's readonly)

I think zone.js can prepare a separate options object instead of mutating the original object, or a wrapper using Object.create(options) or similar.

[imaksp]

Hi @JiaLiPassion here is the minimum reproduction repo:
https://github.com/imaksp/wc-zone-js-issue

Steps:

• clone, and run yarn && yarn dev
• Click on Connect Wallet button
• See the error in console

If you change zone.js version to 0.14.2 it will open QR modal like this without any errors.

[JiaLiPassion]

@imaksp
The reason is the walletconnect lib pass the AbortController directly to the addEventListener function, and the AbortController.signal is readonly, just like @JoostK said, I will create a new Options to fix this issue.

[attilacsanyi]

Unfortunately with zone.js@0.14.4 the issue still present.

@JiaLiPassion did you found a fix without downgrading tozone.js@0.14.2? Thank you so much.