Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zone.js): patch fs.realpath.native as macrotask #54208

Closed
wants to merge 1 commit into from
Closed

fix(zone.js): patch fs.realpath.native as macrotask #54208

wants to merge 1 commit into from

Conversation

arturovt
Copy link
Contributor

@arturovt arturovt commented Feb 2, 2024

This commit updates the implementation of the zone.js fs patch to restore the implementation of realpath.native and patches it as a macrotask, along with other functions of the fs package. This is the only nested function that must be patched.

Closes: #45546

@arturovt
fix(zone.js): patch fs.realpath.native as macrotask
72c80e3 
This commit updates the implementation of the zone.js `fs` patch to
restore the implementation of `realpath.native` and patches it as a macrotask,
along with other functions of the `fs` package. This is the only nested function
that must be patched.

Closes: angular#45546
@arturovt arturovt marked this pull request as ready for review February 2, 2024 08:57
@ngbot ngbot bot added this to the Backlog milestone Feb 2, 2024
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 2, 2024
JiaLiPassion
JiaLiPassion approved these changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 6, 2024
jessicajaniuk pushed a commit that referenced this pull request Feb 6, 2024
@arturovt @thePunderWoman
fix(zone.js): patch fs.realpath.native as macrotask (#54208)
4297005 
This commit updates the implementation of the zone.js `fs` patch to
restore the implementation of `realpath.native` and patches it as a macrotask,
along with other functions of the `fs` package. This is the only nested function
that must be patched.

Closes: #45546

PR Close #54208
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 19fae76.

@arturovt arturovt deleted the fix/45546 branch February 6, 2024 16:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JiaLiPassion JiaLiPassion JiaLiPassion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: zones target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

zone.js/node breaks for fs.realpath.native and fs.realpathSync.native
4 participants
@arturovt @jessicajaniuk @JiaLiPassion @AndrewKushnir