fix(zone.js): add missing APIs to Node.js fs patch
#54396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
force-pushed
the
fix/zone.js-fs-missing-apis
branch
from
2354b5b
to
f49a7ac
Compare
This commit updates the list of Node.js `fs` APIs to be patched because they haven't been updated for a long time. It adds `opendir,lutimes,writev`. For example, the `opendir` method was added to Node.js in version 12.12.0 in 2019, causing some of the APIs to potentially be always called within the `<root>` context. **Note:** There are missing unit tests for these changes because in unit tests, `fs` is patched by Bazel's Node.js rules and its `node_patches.cjs`. However, the APIs are successfully patched in the real production code and are called with the correct context.
arturovt
force-pushed
the
fix/zone.js-fs-missing-apis
branch
from
f49a7ac
to
2a83d24
Compare
AndrewKushnir
added
target: patch
AndrewKushnir
added
action: merge
|
Caretaker note: TGP is "green", this PR is ready for merge. |
AndrewKushnir
added
target: rc
|
This PR was merged into the repository by commit 9e07b62. |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 3, 2024
This commit updates the list of Node.js `fs` APIs to be patched because they haven't been updated for a long time. It adds `opendir,lutimes,writev`. For example, the `opendir` method was added to Node.js in version 12.12.0 in 2019, causing some of the APIs to potentially be always called within the `<root>` context. **Note:** There are missing unit tests for these changes because in unit tests, `fs` is patched by Bazel's Node.js rules and its `node_patches.cjs`. However, the APIs are successfully patched in the real production code and are called with the correct context. PR Close #54396
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the list of Node.js
fsAPIs to be patched becausethey haven't been updated for a long time. It adds
opendir,lutimes,writev.For example, the
opendirmethod was added to Node.js in version 12.12.0 in2019, causing some of the APIs to potentially be always called within the
<root>context.Note: There are missing unit tests for these changes because in unit tests,
fsis patched by Bazel's Node.js rules and itsnode_patches.cjs. However,the APIs are successfully patched in the real production code and are called
with the correct context.