Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after render hook test is flaky in the repository #54813

Closed
pkozlowski-opensource opened this issue Mar 11, 2024 · 2 comments
Closed

after render hook test is flaky in the repository #54813

pkozlowski-opensource opened this issue Mar 11, 2024 · 2 comments
Labels
area: core Issues related to the framework runtime state: has PR
Milestone

Comments

@pkozlowski-opensource
Copy link
Member

Which @angular/* package(s) are the source of the bug?

core

Is this a regression?

Yes

Description

The "does not execute queueStateUpdate if application is destroyed" test is flaky when running test packages/core/test/acceptance and fails with:

Error: 'expect' was used when there was no current spec, this could be because an asynchronous test timed out
    at Env.expect (/Users/pkozlowski/work/github/pkozlowski-opensource/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1945:15)
    at expect (/Users/pkozlowski/work/github/pkozlowski-opensource/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:8267:18)
    at file:///packages/core/test/acceptance/after_render_hook_spec.ts:165:12

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

No response

Anything else?

No response

@pkozlowski-opensource pkozlowski-opensource added the area: core Issues related to the framework runtime label Mar 11, 2024
@ngbot ngbot bot added this to the needsTriage milestone Mar 11, 2024
@JoostK
Copy link
Member

JoostK commented Mar 11, 2024

I have a fix for this in #54801

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime state: has PR
Projects
None yet
Development

No branches or pull requests

2 participants