[17.3.x]: build: follow-up fixes for AIO lighthouse checks #55065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
action: review
angular-robot
bot
added
the
area: build & ci
crisbeto
previously approved these changes
Mar 27, 2024
Looks like the latest versions of Lighthouse and puppeteer are not compatible with our Chromium version from dev-infra. This commit reverts the updates, and fixes the jobs.
devversion
force-pushed
the
follow-up-patch-fix
branch
from
35c63ea
to
cdc5f44
Compare
crisbeto
previously approved these changes
Mar 27, 2024
Update payload size; now matching — seems expected
crisbeto
approved these changes
Mar 27, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the latest versions of Lighthouse and puppeteer are not compatible with our
Chromium version from dev-infra.
This commit reverts the updates, and fixes the jobs.
(technically we need the same in
main— but we won't run angular.io for v18 anymore, so we can leave them to also stop the trap of accidentally updating via Renovate again..)