New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@angular/core:control-flow migration breaks with Greek characters #55085
Labels
area: migrations
Issues related to `ng update` migrations
core: control flow
Issues related to the built-in control flow (@if, @for, @switch)
state: has PR
Milestone
Comments
JeanMeche
added
area: migrations
Issues related to `ng update` migrations
core: control flow
Issues related to the built-in control flow (@if, @for, @switch)
labels
Mar 28, 2024
crisbeto
added a commit
to crisbeto/angular
that referenced
this issue
Mar 29, 2024
…low migration The control flow migration was using a couple of Greek letters as placeholders. This ended up conflicting with templates authored in Greek. These changes use a more obscure placeholder to make conflicts less likely. It also moves the placeholder generation to a centralized function so it's easier to make changes if we decide to update the pattern again. Fixes angular#55085.
atscott
pushed a commit
that referenced
this issue
Mar 29, 2024
…low migration (#55113) The control flow migration was using a couple of Greek letters as placeholders. This ended up conflicting with templates authored in Greek. These changes use a more obscure placeholder to make conflicts less likely. It also moves the placeholder generation to a centralized function so it's easier to make changes if we decide to update the pattern again. Fixes #55085. PR Close #55113
jessicajaniuk
pushed a commit
to jessicajaniuk/angular
that referenced
this issue
Mar 29, 2024
…low migration (angular#55113) The control flow migration was using a couple of Greek letters as placeholders. This ended up conflicting with templates authored in Greek. These changes use a more obscure placeholder to make conflicts less likely. It also moves the placeholder generation to a centralized function so it's easier to make changes if we decide to update the pattern again. Fixes angular#55085. PR Close angular#55113
jessicajaniuk
pushed a commit
to jessicajaniuk/angular
that referenced
this issue
Mar 29, 2024
…low migration (angular#55113) The control flow migration was using a couple of Greek letters as placeholders. This ended up conflicting with templates authored in Greek. These changes use a more obscure placeholder to make conflicts less likely. It also moves the placeholder generation to a centralized function so it's easier to make changes if we decide to update the pattern again. Fixes angular#55085. PR Close angular#55113
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this issue
Apr 6, 2024
…low migration (angular#55113) The control flow migration was using a couple of Greek letters as placeholders. This ended up conflicting with templates authored in Greek. These changes use a more obscure placeholder to make conflicts less likely. It also moves the placeholder generation to a centralized function so it's easier to make changes if we decide to update the pattern again. Fixes angular#55085. PR Close angular#55113
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: migrations
Issues related to `ng update` migrations
core: control flow
Issues related to the built-in control flow (@if, @for, @switch)
state: has PR
Which @angular/* package(s) are the source of the bug?
@angular/core
Is this a regression?
No, never worked right when the template have specific Greek characters
Description
When the template has specific Greek characters in it, the control-flow migration fails consistently; migration done with
ng generate @angular/core:control-flow
.Code that reproduces the error:
is migrated to:
AFAICT the Greek characters
θ
andδ
confuse the migration.Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No exception when running the update command, but the generated template changes produce broken code which breaks compilation:
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
No response
The text was updated successfully, but these errors were encountered: