Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external typings are not referenced anymore #5565

Closed
rolandjitsu opened this issue Dec 3, 2015 · 4 comments
Closed

external typings are not referenced anymore #5565

rolandjitsu opened this issue Dec 3, 2015 · 4 comments

Comments

@rolandjitsu
Copy link

Probably this is by design, but typing such as zone.js, es6-shim and so on are not referenced anymore. You can easily get around this by installing these typings yourself, but there seems to be some issues with a BrowserNodeGlobal that is missing and zone.js referencing a es6-promise which if installed will conflict with es6-shim.

@IgorMinar
Copy link
Contributor

I believe that this was fixed in a48. Can you confirm or provide steps to reproduce with a48?

@rolandjitsu
Copy link
Author

Yeah, it has been fixed 👍

Just one note here, because Angular 2 already includes things like es6-promise and because I do not import angular2/core anywhere in my e2e tests, the TS compiler is throwing errors about missing typings. Of course, if I do include the typings, then I get the duplicate typings messages.

@alexeagle
Copy link
Contributor

The duplicate identifier problems were fixed as of beta.6. You indicated this is fixed, so closing.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants