fix(bundles): rename external-dependencies to angular-polyfills #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes angular#5714 BREAKING CHANGE: The `external-dependencies.js` bundle was removed. Use `angular-polyfills.js` instead.
| var rename = require('gulp-rename'); | ||
| var uglify = require('gulp-uglify'); | ||
|
|
||
| // minify production bundles | ||
| return gulp.src([ | ||
| 'dist/js/bundle/external-dependencies.js', | ||
| 'dist/js/bundle/angular-polyfills.js', |
There was a problem hiding this comment.
ok, sorry. it should really be angular2-polyfills.js to align it with angular2.* files. Sorry! I didn't see it until I looked at the diff.
IgorMinar
added
pr_state: LGTM
action: cleanup
|
@jelbourn can you please rename |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5714
BREAKING CHANGE:
The
external-dependencies.jsbundle was removed.Use
angular-polyfills.jsinstead.