fix(perf): faster looseIdentical implementation #6364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ? _looseIdentical(a, b) | ||
| : identical(a, b); | ||
|
|
||
| bool _looseIdentical(a, b) => |
There was a problem hiding this comment.
Add a comment why this should stay separate.
tbosch
added
pr_state: LGTM
action: cleanup
Remove String type check in looseIdentical in JS-mode. It is not necessary as dart2js already compiles `identical` to `===` which compares string contents. Inline call sites. This improves change detection of plain fields by 40%. On a large internal app the improvement is 5%.
yjbanov
force-pushed
the
faster-looseIdentical
branch
from
3d9079c
to
d67f649
Compare
yjbanov
added
action: merge
|
Merging PR #6364 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-6364. |
|
Merging PR #6364 on behalf of @rkirov to branch presubmit-rkirov-pr-6364. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove String type check in looseIdentical in JS-mode. It is not necessary as dart2js already compiles
identicalto===which compares string contents. Inline call sites.This improves change detection of plain fields by 40%. On a large internal app the improvement is 5%.