refactor(WebWorker): Rename WORKER_RENDER_APP to WORKER_RENDER_APPLICATION #6378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jteplitz
added
action: review
| @@ -8,7 +8,7 @@ export 'package:angular2/src/platform/worker_render_common.dart' | |||
| initializeGenericWorkerRenderer; | |||
There was a problem hiding this comment.
Worker render app common export needs to be aliased as well. Causing Travis failure
jeffbcross
added
pr_state: LGTM
action: cleanup
jteplitz
force-pushed
the
worker-render-application
branch
3 times, most recently
from
ea7b359
to
acc7e00
Compare
…ATION BREAKING CHANGE WORKER_RENDER_APP is now deprecated. Use WORKER_RENDER_APPLICATION instead WORKER_RENDER_APP_COMMON has been replaced by WORKER_RENDER_APPLICATION_COMMON closes angular#6184
jteplitz
added
action: merge
|
Merging PR #6378 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-6378. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
WORKER_RENDER_APP is now deprecated. Use WORKER_RENDER_APPLICATION instead
closes #6184