Set response.ok #6503
Closed
Set response.ok #6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for this. when you get the tests passing, please update your commit message to meet the guidelines |
Utsav2
force-pushed
the
response-ok
branch
2 times, most recently
from
86d6641
to
a5b0d5d
Compare
The ok property was not being set on response objects. It's now set based on the status code. Closes angular#6390
|
@robwormald Thanks, have a look now? |
|
I think response.ok should be false for any Network Error too |
2 tasks
KiaraGrouwstra
pushed a commit
to KiaraGrouwstra/angular
that referenced
this pull request
Jun 21, 2016
The ok property was not being set on response objects. It's now set based on the status code. Closes angular#6390 Closes angular#6503
hbkrunal
pushed a commit
to hbkrunal/angular
that referenced
this pull request
Sep 15, 2016
The ok property was not being set on response objects. It's now set based on the status code. Closes angular#6390 Closes angular#6503
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #6390