New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(WebWorkers): Add support for transitionend events. #6654
Conversation
Map<String, dynamic> serializeTransitionEvent(dynamic e) { | ||
var serialized = serializeGenericEvent(e); | ||
serialized['propertyName'] = e.propertyName; | ||
serialized['elapsedTime'] = e.propertyName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not e.elapsedTime
? Same question for next line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed.
a8fb8d2
to
2733511
Compare
var serialized = serializeGenericEvent(e); | ||
serialized['propertyName'] = e.propertyName; | ||
serialized['elapsedTime'] = e.elapsedTime; | ||
serialized['psuedoElement'] = e.psuedoElement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mis-spelled :)
pseudoelement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awkward. Fixed.
2733511
to
89ef689
Compare
@@ -31,6 +31,10 @@ class GenericEvent { | |||
Point get page => _getPoint('page'); | |||
Point get screen => _getPoint('screen'); | |||
|
|||
String get propertyName => properties['propertyName']; | |||
num get elapsedTime => properties['elapsedTime']; | |||
String get psuedoElement => properties['psuedoElement']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also mis-spelled.
pseudoelement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
89ef689
to
07f136b
Compare
07f136b
to
18a90d2
Compare
Merging PR #6654 on behalf of @rkirov to branch presubmit-rkirov-pr-6654. |
flaky saucelabs is failing https://travis-ci.org/angular/angular/builds/105066438 manually pushed at c2a38c0 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #6649