Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebWorkers): Add support for transitionend events. #6654

Closed
wants to merge 1 commit into from

Conversation

jteplitz
Copy link
Contributor

Closes #6649

@jteplitz jteplitz added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 22, 2016
Map<String, dynamic> serializeTransitionEvent(dynamic e) {
var serialized = serializeGenericEvent(e);
serialized['propertyName'] = e.propertyName;
serialized['elapsedTime'] = e.propertyName;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not e.elapsedTime? Same question for next line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed.

var serialized = serializeGenericEvent(e);
serialized['propertyName'] = e.propertyName;
serialized['elapsedTime'] = e.elapsedTime;
serialized['psuedoElement'] = e.psuedoElement;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mis-spelled :)

pseudoelement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awkward. Fixed.

@@ -31,6 +31,10 @@ class GenericEvent {
Point get page => _getPoint('page');
Point get screen => _getPoint('screen');

String get propertyName => properties['propertyName'];
num get elapsedTime => properties['elapsedTime'];
String get psuedoElement => properties['psuedoElement'];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also mis-spelled.
pseudoelement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jteplitz jteplitz added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 23, 2016
@mary-poppins
Copy link

Merging PR #6654 on behalf of @rkirov to branch presubmit-rkirov-pr-6654.

@rkirov
Copy link
Contributor

rkirov commented Jan 27, 2016

flaky saucelabs is failing https://travis-ci.org/angular/angular/builds/105066438

manually pushed at c2a38c0

@rkirov rkirov closed this Jan 27, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transitionend not supported on WebWorkers
6 participants