fix(compiler): throw an error if variable with the same name is already defined.

[Ne4istb]

No description provided.

[zoechi]

Does this also throw when the variable is added multiple times like

<div *ngFor="#item of items" #somevar></div>

This is sometimes handy and didn't cause issues for me so far.

[Ne4istb]

@zoechi This change will not influence your case because it checks duplicates on template level, and ngFor creates separate templates. I've checked it locally :)

[zoechi]

@Ne4istb great, thanks for the feedback :)

[mhevery]

I am sorry for the delay in getting back to you.

Please add one more tests, which says that the same variables across different templates are OK.

<div #a>
  <span *ngIf="..." #a>OK</span>
</div>

The above is allowed.

[Ne4istb]

Will do soon

[Ne4istb]

@tbosch What kind of cleanup should be done?
P.S. presubmit.sh does not work now, i guess, because of changes in gulpfile.js. How can I run any code style validation?

[tbosch]

The test that @mhevery mentioned...

[tbosch]

Try to rebase, master should be good again.

[Ne4istb]

@tbosch
test is already there with template

<div #a><template #a><span>OK</span></template></div>

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}