Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 7332 #7364

Closed
wants to merge 4 commits into from
Closed

Pr 7332 #7364

wants to merge 4 commits into from

Conversation

IgorMinar
Copy link
Contributor

rebased version of #7332

petebacondarwin and others added 4 commits March 1, 2016 15:56
The current router is passed to the current component via a binding.
To indicate that this is an angular provided object, this commit
renames the binding to `$router`.

BREAKING CHANGE:

The recently added binding of the current router to the current component
has been renamed from `router` to `$router`.

So now the recommended set up for your bindings in your routed component
is:

```js
{
  ...
  bindings: {
    $router: '<'
  }
}
```
The current router is passed to the current component via a binding.
To indicate that this is an angular provided object, this commit
renames the binding to `$router`.

BREAKING CHANGE:

The recently added binding of the current router to the current component
has been renamed from `router` to `$router`.

So now the recommended set up for your bindings in your routed component
is:

```js
{
  ...
  bindings: {
    $router: '<'
  }
}
```
@petebacondarwin deserves credit for most of this commit.

This allows you to specify a regex and serializer function instead
of the path DSL in your route declaration.

```
@RouteConfig([
  { regex: '[a-z]+.[0-9]+',
    serializer: (params) => `{params.a}.params.b}`,
    component: MyComponent }
])
class Component {}
```

Closes angular#7325
Closes angular#7126
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@IgorMinar IgorMinar mentioned this pull request Mar 2, 2016
@naomiblack naomiblack added action: merge The PR is ready for merge by the caretaker P1: urgent feature Issue that requests a new feature labels Mar 2, 2016
@mary-poppins
Copy link

User @vikerman does not have PR merging privileges.

@mary-poppins
Copy link

Merging PR #7364 on behalf of @vikerman to branch presubmit-vikerman-pr-7364.

@vikerman
Copy link
Contributor

vikerman commented Mar 3, 2016

Merged manually into master. Closing

@vikerman vikerman closed this Mar 3, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: no feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants