refactor(dart/transform): AnnotationMatcher tests #7463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were previously not being run. Bring them up to modern usage, move them to package:test, and include them in transform.server.spec.dart.
kegluneq
added
comp: dart-transformer
action: review
|
the test changes LGTM, but I don't see the change that includes them in transform.server.spec.dart. Did that get left out from the commit? |
jakemac53
removed
the
action: review
| import 'common/async_string_writer_tests.dart' as asyncStringWriter; | ||
| import 'common/code/ng_deps_code_tests.dart' as ngDepsCode; | ||
| import 'common/ng_meta_test.dart' as ngMetaTest; | ||
| import 'common/url_resolver_tests.dart' as urlResolver; | ||
|
|
||
| main() { | ||
| group('AnnotationMatcher', annotationMatcher.allTests); |
There was a problem hiding this comment.
@juliemr , this line adds the changes to transform.server.spec.dart
|
LGTM too. |
|
TAP - 0 affected targets |
|
Merging PR #7463 on behalf of @vikerman to branch presubmit-vikerman-pr-7463. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @juliemr
These tests were previously not being run.
Bring them up to modern usage, move them to package:test, and include
them in transform.server.spec.dart.