Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): RouterOutlet loads component twice in a race condition #7545

Closed
wants to merge 1 commit into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Mar 11, 2016

bug fix #7497

  • What is the current behavior? (You can also link to an open issue here)

During race condition it is possible that the routerOutlet will activate a component multiple times.

  • What is the new behavior (if this is a feature change)?

Ensure that activation can happen only once.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

@mhevery
Copy link
Contributor Author

mhevery commented Mar 11, 2016

@tbosch this is a fix for #7497. I need help writing the test which demonstrates the issue.

@mhevery
Copy link
Contributor Author

mhevery commented Mar 16, 2016

@tbosch LGTM, per our discussion

@jelbourn jelbourn changed the title Issue7497 fix(router): RouterOutlet loads component twice in a race condition Mar 16, 2016
@mary-poppins
Copy link

Merging PR #7545 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7545.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RouterOutlet loads component 2x in a race condition
5 participants