feat(Compiler): Allow overriding the projection selector #7742

vicb · 2016-03-23T22:42:40Z

Please check if the PR fulfills these requirements
The commit message follows our guidelines:
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

BREAKING CHANGE:

For static content projection, elements with *-directives are now matched against the element itself vs the template before.

    <p *ngIf="condition" foo></p>

Before:

    // Use the implicit template for projection
    <ng-content select="template"></ng-content>

After:

    // Use the actual element for projection
    <ng-content select="p[foo]"></ng-content>

tbosch · 2016-03-23T23:12:04Z

modules/angular2/src/compiler/template_parser.ts

-      parsedElement =
-          new NgContentAst(this.ngContentCount++, elementNgContentIndex, element.sourceSpan);
+
+      let ngContentIndex =


Move this out of the if right after the var projectionSelector =.

fixes angular#6303 BREAKING CHANGE: For static content projection, elements with *-directives are now matched against the element itself vs the template before. <p *ngIf="condition" foo></p> Before: // Use the implicit template for projection <ng-content select="template"></ng-content> After: // Use the actual element for projection <ng-content select="p[foo]"></ng-content>

mary-poppins · 2016-03-24T20:04:38Z

Merging PR #7742 on behalf of @kara to branch presubmit-kara-pr-7742.

fixes angular#6303 BREAKING CHANGE: For static content projection, elements with *-directives are now matched against the element itself vs the template before. <p *ngIf="condition" foo></p> Before: // Use the implicit template for projection <ng-content select="template"></ng-content> After: // Use the actual element for projection <ng-content select="p[foo]"></ng-content> Closes angular#7742

angular-automatic-lock-bot · 2019-09-08T19:22:37Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Mar 23, 2016

vicb assigned tbosch Mar 23, 2016

tbosch reviewed Mar 23, 2016
View reviewed changes

tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 23, 2016

tbosch assigned vicb and unassigned tbosch Mar 23, 2016

tbosch added the pr_state: LGTM label Mar 23, 2016

vicb force-pushed the 0323-projAs branch from b59f9cf to 2a2282d Compare March 23, 2016 23:34

vicb removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 23, 2016

vicb force-pushed the 0323-projAs branch from 2a2282d to 8b6d0d3 Compare March 24, 2016 00:05

vicb added the action: merge The PR is ready for merge by the caretaker label Mar 24, 2016

kara added the zomg_admin: do merge label Mar 24, 2016

mary-poppins removed the zomg_admin: do merge label Mar 24, 2016

mhevery closed this in aa966f5 Mar 24, 2016

bradlygreen added this to the Angular 2 Release Candidate milestone Apr 4, 2016

vicb deleted the 0323-projAs branch June 23, 2016 17:43

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Compiler): Allow overriding the projection selector #7742

feat(Compiler): Allow overriding the projection selector #7742

vicb commented Mar 23, 2016

tbosch Mar 23, 2016

mary-poppins commented Mar 24, 2016

angular-automatic-lock-bot bot commented Sep 8, 2019

feat(Compiler): Allow overriding the projection selector #7742

feat(Compiler): Allow overriding the projection selector #7742

Conversation

vicb commented Mar 23, 2016

tbosch Mar 23, 2016

Choose a reason for hiding this comment

mary-poppins commented Mar 24, 2016

angular-automatic-lock-bot bot commented Sep 8, 2019