fix(angular1_router): delay view update until activate promise gets fullfilled #7777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ullfilled If the $routerOnActivate hook returns a promise, the navigation is commited, once the promise gets fullfilled but the view is updated immediately. This commit delays the view update so that both (view and url) are updated at the same time.
Mischi
force-pushed
the
fix-onActivate-view-update
branch
from
7c52e19
to
b3a9e20
Compare
|
@petebacondarwin what do you think? |
|
This looks like it is doing the right thing. I will review it in detail later this week. |
KiaraGrouwstra
pushed a commit
to KiaraGrouwstra/angular
that referenced
this pull request
Jun 10, 2016
…ullfilled If the $routerOnActivate hook returns a promise, the navigation is commited, once the promise gets fullfilled but the view is updated immediately. This commit delays the view update so that both (view and url) are updated at the same time. Closes angular#7777
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
If the $routerOnActivate hook returns a promise, the navigation
is commited once the promise gets fullfilled but the view
is updated immediately.
View and url are not synchron until the promise gets fullfilled.
This PR delays the view update so that both (view and url) are
updated at the same time.
This is the expected behaviour if i understand the docs correct.
No breaking changes intended.
CC: @davidreher